[R] Fix winbuilder check warnings. #11830
Merged
+28
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses R package check warnings by making several corrections across the codebase. The changes include proper handling of cache directory paths, updating C function declarations to use proper parameter specifications, relocating configuration headers to the correct directory, and adding thread control directives in R documentation examples.
Key changes:
- Enhanced cache path handling to properly detect and handle directory inputs in the
MakeCachePrefixfunction - Fixed C function declarations to use
(void)instead of()for parameterless functions, which is the correct C standard practice - Relocated
config.hfrom the R package root to thesrc/subdirectory for proper R package structure
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/data/sparse_page_source.cc | Added directory detection logic to cache prefix handling and updated copyright year |
| tests/cpp/helpers.cc | Updated test to use MakeCachePrefix wrapper for consistency with production code |
| ops/script/test_r_package.py | Added removal of bootstrap.R file during R package creation |
| R-package/src/init.c | Fixed function declarations to use (void) instead of () for parameterless functions |
| R-package/src/config.h.in | Updated generated file comment to reflect correct path |
| R-package/configure.ac | Changed config header path from config.h to src/config.h |
| R-package/configure | Regenerated configure script with updated config header path |
| R-package/man/predict.xgb.Booster.Rd | Added thread control directive for R CMD check |
| R-package/man/a-compatibility-note-for-saveRDS-save.Rd | Added thread control directive for R CMD check |
| R-package/R/xgb.Booster.R | Added thread control directive in example documentation |
| R-package/R/utils.R | Added thread control directive in example documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trivialfis
changed the title
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Nov 24, 2025
trivialfis
added a commit
that referenced
this pull request
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.